fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30288 )
Change subject: trxcon: trx_data_rx_cb(): properly parse timeslot number ......................................................................
trxcon: trx_data_rx_cb(): properly parse timeslot number
Remove the range check because it makes no sense anymore.
Change-Id: I1010cf39f61b8845acce632c19c74df892fc5acb --- M src/host/trxcon/src/trx_if.c 1 file changed, 1 insertion(+), 6 deletions(-)
Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified
diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c index 2c0b286..06f0a07 100644 --- a/src/host/trxcon/src/trx_if.c +++ b/src/host/trxcon/src/trx_if.c @@ -648,7 +648,7 @@ burst = (sbit_t *)&buf[8];
bi = (struct trxcon_phyif_burst_ind) { - .tn = buf[0], + .tn = buf[0] & 0x07, .fn = osmo_load32be(buf + 1), .rssi = -(int8_t) buf[5], .toa256 = (int16_t) (buf[6] << 8) | buf[7], @@ -664,11 +664,6 @@ burst[i] = 127 - buf[8 + i]; }
- if (bi.tn >= 8) { - LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, "Illegal TS %d\n", bi.tn); - return -EINVAL; - } - if (bi.fn >= 2715648) { LOGPFSMSL(trx->fi, DTRXD, LOGL_ERROR, "Illegal FN %u\n", bi.fn); return -EINVAL;
-
fixeria