Attention is currently required from: laforge.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42170?usp=email )
Change subject: dfu: mainloop: work on a local copy of dfu_state ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
ok, so I think we agree this is not neccessary after all? Given that all loads/stores are atomic, a […]
AFAIU: Pau asked if this assignment itself is atomic (last_dfu_state = dfu_state) and if not would need a CRITICAL section, where we agreed, the assignment itself is atomic.
About this assignment, I want to make sure the mainloop would loop over and only does one thing based based on the dfu_state. Trying to keep the code path simple and keep away from side effects.
Otherwise a loop run could run through different states and does multiple things
-
lynxis lazus