Attention is currently required from: laforge, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28286 )
Change subject: add libosmo-gtlv, moved from osmo-upf.git
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
I agree with @laforge, let's keep same structure
for all libs: […]
- I thought it would be quick, but i've already spent hours on
that, it is frustrating. various tasks are stalled because of this, and more and more
trivial nonsense seems to show up around every corner. I'd rather do useful work.
- Changing naming just because the repository changes is completely against my opinion.
Removing the dash needs changes in libosmo-pfcp, osmo-upf as well as osmo-hnbgw. I
don't want that to happen, moving to another repos should not require changes to the
users. Ideally we move the Makefile.am stuff 1:1.
Having a separate libosmo-gtlv.git
- does not affect libosmocore
- does not require build style and naming changes
Least grunt work is having gtlv in libosmo-pfcp.git,
we postpone this discussion and don't proliferate overhead needed for
build jobs, git mirrors etc.
I am not convinced that any of this is worth any time spent in the first place, i feel
this is spinning off on a tangent.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28286
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71
Gerrit-Change-Number: 28286
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Jun 2022 11:27:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment