[XS] Change in osmo-uecups[master]: tun_device: Make sure struct iphdr access is 4-byte aligned - gerrit-log

31 Jul 2025


      Attention is currently required from: Hoernchen, fixeria, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email )
Change subject: tun_device: Make sure struct iphdr access is 4-byte aligned
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File daemon/tun_device.c:
https://gerrit.osmocom.org/c/osmo-uecups/+/40787/comment/e42cc829_46ef58ae?u... :
PS2, Line 208: 	uint8_t base_buffer[payload_off_4byte_aligned + MAX_UDP_PACKET];
I would expect there are nice compiler pragmas/macros that allow for such alignment? I know the Linux kernel has related macros.  Not critical, just my 2 cents.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I610c8e9b150c234b7d4997e0b1c4d4a9ce4de9ec
Gerrit-Change-Number: 40787
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 31 Jul 2025 12:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes