Attention is currently required from: dexter.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 )

Change subject: PCUIF_Types: fix record PCUIF_pch_dt ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417/comment/5ea7373a_f4851... PS1, Line 10: it would pad the data with zeros if it does not fit the : specified length. This is unwanted

My observation here is that when ALIGN(left) is used, the buffer is padded with zeros at the beginni […]

This is weird. We have this attribute applied to `data` field of `PCUIF_data` and it seems to work as expected. Looking at the TITAN's reference guide [1], I see "Default value: left for octetstrings, right for all other types". Perhaps it works different for other data types than octetstrings.

All in all, I am fine with merging this patch, but I find the commit message a bit misleading. It says that padding is unwanted, but in reality it is wanted, but r-padding instead of l-padding. Could you please rephrase/update it? Thanks!

[1] https://github.com/eclipse/titan.core/blob/master/usrguide/referenceguide/4-...