Attention is currently required from: dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 )
Change subject: PCUIF_Types: fix record PCUIF_pch_dt
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417/comment/5ea7373a_f485…
PS1, Line 10: it would pad the data with zeros if it does not fit the
: specified length. This is unwanted
My observation here is that when ALIGN(left) is used,
the buffer is padded with zeros at the beginni […]
This is weird. We have this
attribute applied to `data` field of `PCUIF_data` and it seems to work as expected.
Looking at the TITAN's reference guide [1], I see "Default value: left for
octetstrings, right for all other types". Perhaps it works different for other data
types than octetstrings.
All in all, I am fine with merging this patch, but I find the commit message a bit
misleading. It says that padding is unwanted, but in reality it is wanted, but r-padding
instead of l-padding. Could you please rephrase/update it? Thanks!
[1]
https://github.com/eclipse/titan.core/blob/master/usrguide/referenceguide/4…
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I011eb2496b1422c49736b227dfa1e2a2d6096d67
Gerrit-Change-Number: 33417
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Jun 2023 12:36:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment