Attention is currently required from: laforge.
wbokslag has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-tetra/+/34169 )
Change subject: Added crypto support
......................................................................
Patch Set 2:
(1 comment)
File src/crypto/tetra_crypto.c:
https://gerrit.osmocom.org/c/osmo-tetra/+/34169/comment/7eea84e2_89994c3f
PS2, Line 249: // key->addr, key->index, tcs->hn,
tetra_tdma_time_dump(tdma_time), tmpdu_offset, ct_len);
why is this (and similar lines below) commented-out in
this patch? I'd suspect it would work just as […]
You are right, I have been
making some general modifications to have the code conform more to what I believe to be
the osmocom standard, I could/should probably have refrained from making such changes in
this patch. I have removed it in an amended patch.
Log levels seem like a good idea for the future. The particular print in this example is
rarely of interest. These, and some other prints elsewhere in the code, may be useful when
debugging/understanding network traffic, but not to the majority of users.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-tetra/+/34169
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I0c0227cf5b747bd5032602390175b898173f6ae6
Gerrit-Change-Number: 34169
Gerrit-PatchSet: 2
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 29 Aug 2023 10:22:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment