Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39265?usp=email ) Change subject: client: Support generation of pcapng file format ...................................................................... Patch Set 8: Code-Review+1 (3 comments) File doc/manuals/chapters/client.adoc: https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/55a54038_dd796206?us… : PS8, Line 59: reate create File include/osmo-pcap/osmo_pcap_file.h: https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/819747a2_876b4d23?us… : PS8, Line 87: /* uint32_t block_total_length */ looks like a leftover, because block_total_length is already in line 85 File src/osmo_client_network.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/6b1a454b_24189fab?us… : PS8, Line 389: . (remove the dot?) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I3c80518a1e53a1f77e1aca8dfa83f683f9516ad6 Gerrit-Change-Number: 39265 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2025 15:45:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes