Attention is currently required from: daniel, laforge, pespin.

osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39265?usp=email )

Change subject: client: Support generation of pcapng file format ......................................................................

Patch Set 8: Code-Review+1

(3 comments)

File doc/manuals/chapters/client.adoc:

https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/55a54038_dd796206?usp... : PS8, Line 59: reate create

File include/osmo-pcap/osmo_pcap_file.h:

https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/819747a2_876b4d23?usp... : PS8, Line 87: /* uint32_t block_total_length */ looks like a leftover, because block_total_length is already in line 85

File src/osmo_client_network.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/6b1a454b_24189fab?usp... : PS8, Line 389: . (remove the dot?)