fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42350?usp=email )

Change subject: s1gw: make S1AP_Server.f_conn_add() return nothing ......................................................................

s1gw: make S1AP_Server.f_conn_add() return nothing

The index of a new entry is not used anywhere, so do not return it.

Change-Id: I8df3985a665ae919849559ea8cf0fd33b5b22df8 --- M s1gw/S1AP_Server.ttcn 1 file changed, 2 insertions(+), 5 deletions(-)

Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified

diff --git a/s1gw/S1AP_Server.ttcn b/s1gw/S1AP_Server.ttcn index 5bd83a4..df91eaa 100644 --- a/s1gw/S1AP_Server.ttcn +++ b/s1gw/S1AP_Server.ttcn @@ -128,9 +128,9 @@ return -1; }

-/* add a new connection, return its index */ +/* add a new connection */ private function f_conn_add(ConnectionId conn_id) -runs on S1AP_Server_CT return integer { +runs on S1AP_Server_CT { var ConnData conn := { conn_id, - }; var integer idx;

@@ -139,11 +139,8 @@ mtc.stop; }

- idx := lengthof(g_conn_list); g_conn_list := g_conn_list & { conn }; log("Connection (id=", conn_id, ") is registered"); - - return idx; }

/* del an existing connection */