Attention is currently required from: osmith, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34575?usp=email )
Change subject: gprs_rlcmac_sched: check if we really use direct phy ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
Yes, my quick understanding is that the flag is used to signal "direct phy". […]
I have renamed the flag now in a patch before this one. So this part should be consistent now. (I do not think that we need flags to describe the exact PHY platform now. I also think that flags are probably not the right way to signal something like that. There should be an enum.)
We may remove the ENABLE_DIRECT_PHY conditional compiling in locations where we do not have to guard phy specific function calls. This is the case for the two code locations in question.