Attention is currently required from: osmith, pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/27646 )
Change subject: jenkins: Validate gsm 08.58 IEs are added to tlv_definition
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File include/osmocom/gsm/protocol/gsm_08_58.h:
https://gerrit.osmocom.org/c/libosmocore/+/27646/comment/89fc2760_558a2efe
PS3, Line 356: RSL_IE_LLP_APDU,
There's lots of lines above that don't have
" = ". These are not covered by the check. […]
I agree, can, will those be
checked as well?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27646
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id8a679ca43eb0fcc4882780e9a95ec21c7f51972
Gerrit-Change-Number: 27646
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Apr 2022 11:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment