Attention is currently required from: jolly.

pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email )

Change subject: Add multiple messages buffers to io_uring write operations ......................................................................

Patch Set 6:

(3 comments)

File src/core/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/1b6fd4ed_62c4364d?u... : PS4, Line 248: lh = iofd->tx_queue.msg_queue.prev;

I added the suggested llist_last_entry_or_null().

You added it to libosmocore but apparently not using it here?

https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/ed8b74ac_3c8644c8?u... : PS4, Line 517: msghdr = iofd_txqueue_tail(iofd);

Done

Not done, not answered, no comment explaining in code.

https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/e3905381_70389350?u... : PS4, Line 539: rc = iofd_txqueue_enqueue(iofd, msghdr);

If io_uring processes a msghdr, it has been removed from the queue before, so everything within the […]

Done