Attention is currently required from: keith, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/34150
)
Change subject: vty: include local port when dumping RTP conns
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp/mgcp_conn.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/d9e1830f_e6a2f009
PS1, Line 373: "rtp:%u<->%u rtcp:%u)",
I think you probably want to clearly print remote and
local IP+port together so it becomes way clear […]
You could also do something like
"l:%s<->r:%s (rtcp: %u<->%u)" or alike.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/34150
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132
Gerrit-Change-Number: 34150
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Aug 2023 09:09:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment