Attention is currently required from: daniel, fixeria, fixeria, pespin.
matanp has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/35747?usp=email )
Change subject: ctrl: Add ms power
......................................................................
Patch Set 7:
(2 comments)
File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/35747/comment/abde2d43_8f1cb38c
PS3, Line 2: * (C) 2013-2015 by Holger Hans Peter Freyther
: * (C) 2013-2022 by
I am not a Copyright expert, but this still does not
look right to me. […]
I am not an expert either, I thought that since it is an
osmocom project, sysmocom should have the copyright (I am only contributing it) - I will
replace with my name
https://gerrit.osmocom.org/c/osmo-bsc/+/35747/comment/53ce488c_be23b602
PS3, Line 17: * You should have received a copy of the GNU Affero General Public License
:
No need to remove this whole part.
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/35747?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6f556b66011be6126d6bac31a14101ba37f81cc4
Gerrit-Change-Number: 35747
Gerrit-PatchSet: 7
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator(a)gmail.com>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: fixeria <axilirator(a)gmail.com>
Gerrit-Comment-Date: Wed, 14 Feb 2024 10:58:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: comment