Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/33097 )
Change subject: Port to new libosmogsm 'struct osmo_sub_auth_data2'
......................................................................
Patch Set 1:
(8 comments)
File tests/auc/gen_ts_55_205_test_sets/func_template.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7794):
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/f4d8027c_c515b682
PS1, Line 27: struct osmo_sub_auth_data2 aud2g;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7794):
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/a27374e3_56cb45b2
PS1, Line 27: struct osmo_sub_auth_data2 aud2g;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7794):
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/3fc72ec1_7ab54ef6
PS1, Line 28: struct osmo_sub_auth_data2 aud3g;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7794):
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/8a5af877_a67b8220
PS1, Line 28: struct osmo_sub_auth_data2 aud3g;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7794):
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/7f13e6b6_eedd9ab6
PS1, Line 34: aud2g = (struct osmo_sub_auth_data2){{ 0 }};
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7794):
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/00eaea40_24559a87
PS1, Line 34: aud2g = (struct osmo_sub_auth_data2){{ 0 }};
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7794):
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/f46e8d93_39a7e46f
PS1, Line 36: aud3g = (struct osmo_sub_auth_data2){{
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7794):
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/bd3a626a_bc2b69dc
PS1, Line 36: aud3g = (struct osmo_sub_auth_data2){{
please, no spaces at the start of a line
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/33097
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I3207c7bfb73e9ff5471e5c26b66639549e4d48a2
Gerrit-Change-Number: 33097
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 03 Jun 2023 17:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment