fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27510 )
Change subject: fixup: gsm48_make_ho_cmd(): optionally add Synchronization Indication IE ......................................................................
fixup: gsm48_make_ho_cmd(): optionally add Synchronization Indication IE
This was overlooked during the code review. GCC does not complain because internally both 'enum handover_scope' and 'bool' are interpreted as 'int'. Found this while running my WIP testcase TC_srvcc_eutran_to_geran_a5_3. This change makes it pass.
Change-Id: I807fd4a0e700e54c67ca3547d9c0c1b442dd1c54 Fixes: I4e5b1163a71443d706f14ce4bfd5c2294c320432 Related: SYS#5838 --- M src/osmo-bsc/handover_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified Jenkins Builder: Verified
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 5ae3787..488f370 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -1216,7 +1216,7 @@ struct handover *ho = &conn->ho;
struct msgb *rr_ho_cmd = gsm48_make_ho_cmd(ho->new_lchan, - ho->async, ho->scope, + ho->scope, ho->async, ho->new_lchan->ms_power, ho->ho_ref); if (!rr_ho_cmd) {