Attention is currently required from: fixeria, laforge, pespin.

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email )

Change subject: gsm0808: add knowledge of TW-TS-003 BSSMAP IE ......................................................................

Patch Set 2:

(1 comment)

File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/c/libosmocore/+/36669/comment/4c1ecbfa_4969098e PS1, Line 2316: [GSM0808_IE_THEMWI_RTP_EXTENSIONS] = { TLV_TYPE_TV },

You may want to keep this as TLV to match the Abis IE.

The A interface can't be changed as easily as Abis here: while Abis-IP is essentially a private interface fully inside Osmocom kingdom, the AoIP interface (3GPP specs plus TW-TS-003 extension) connects two different fiefdoms: Osmocom kingdom on BSS side and W. R. of Themyscira on CN side. TW-TS-003 is thus an external ICD, unlike Osmocom-internal definitions like the Abis IE, and TW-TS-003 section 5.2 defines this IE as having TV format. It is true that TW-TS-003 is still a very new spec and can be revised, but revising TW-TS is a more formal/involved process than Gerrit here.

However, to make it easier to merge the most essential part (reserving IEI code point 0xF2 for Themyscira and identifying it by the same symbolic name as in TW=TS-003 spec), I'll resubmit this patch with just protocol/gsm_08_08.h part kept, and drop this TLV decoder addition for now.