Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31077 )
Change subject: modem: Initial integration of libosmo-gprs-rlcmac ......................................................................
Patch Set 1:
(3 comments)
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/ab09ecb5_4bddf7fe PS1, Line 149: owneserip ownership
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/8bd592d3_0f0a4b44 PS1, Line 151: RLCMAC-GRR-UNITDATA-IND, we just need to adapt the header. will this always be the case in the future? maybe it makes sense to use osmo_static_assert on the size and/or add comments in rlcmac_prim.h / llc_prim.h that this assumption is made?
same in modem_rlcmac_handle_grr
File src/host/layer23/src/modem/rlcmac.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/d2f25c87_b2daaf65 PS1, Line 78: LL RLCMAC GMMRR