Attention is currently required from: laforge, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320 )
Change subject: sccp_scoc.c: fix infinite loop on conn ID exhaustion
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/fe4a43ed_5372bcca
PS1, Line 17: entire SCCP conn id number space before exiting in failure.
If you want a faster lookup, I think the only way to
do this is to move away from a per-instance lin […]
Done
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/3eee7645_fd34777e
PS1, Line 551: if (!max_attempts || max_attempts > 0x00FFFFFE) {
I really see no much point in having max_attempts
configurable as param here, it should simply be se […]
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/8442ff6e_b539f079
PS1, Line 589: 0
You forgot to update this call to pass only 1 param.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ib64e0cb1ae0cc8b7bebcb2a352d4068b496b304a
Gerrit-Change-Number: 32320
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Apr 2023 16:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment