[M] Change in osmo-ggsn[master]: Refactor tun_t fields and alloc APIs - gerrit-log

25 Oct 2024


      Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38524?usp=email )
Change subject: Refactor tun_t fields and alloc APIs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File lib/tun.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38524/comment/3bddc0a0_b5bdbd5c?usp... :
PS1, Line 111: tun->devname[IFNAMSIZ - 1] = 0;
This is redundant because:
* the whole buffer is NUL-initialized by `talloc_zero()`,
* `osmo_strlcpy()` does NUL-termination if `src` is not empty.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38524?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ic71f91c62cd5bd48c6d35534eaac2091e4c69735
Gerrit-Change-Number: 38524
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 25 Oct 2024 13:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes