Attention is currently required from: laforge.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email )

Change subject: s2b: allow to set the restart counter/recovery field ......................................................................

Patch Set 3:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/8e639807_1613a... : PS2, Line 9: counter a 8 bit value

**is** a 8 bit value

Done

File src/epdg_gtpc_s2b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/59ba705a_c5fdc... : PS2, Line 112: monotonic timer could be to reproducible on systems

What do you mean here? This comment is confusing...

maybe it's better now.

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/866d405b_f06fd... : PS2, Line 115: UserConfig

This argument has two different names: `Options` in `start_link()` and `UserConfig` here. […]

The other values are mandatory. This one is an optional one. I would like to keep it for this commit. If changes are necessary, this should go into another commit.