[S] Change in libosmocore[master]: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9] - gerrit-log

15 Sep 2023


      Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email )
Change subject: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9]
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1: 
well, it is probably simply a question of endianness of the underlying CPU, right?  It's a 16 bit value, and you can either do htons/ntohs on it and use #defines in one order, or not do any htons/ntohs + assume running on little-endian and have the #define the other way?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I85316af9b57e8113077305798cb2d82a24e48e00
Gerrit-Change-Number: 34427
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 15 Sep 2023 08:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment