Attention is currently required from: fixeria.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34517?usp=email )
Change subject: SMS over GSUP: correctly route GSUP responses to MT SMS ......................................................................
Patch Set 1:
(2 comments)
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/c/osmo-msc/+/34517/comment/8539858e_f6df51b5 PS1, Line 1258: talloc_size
FYI, you could use `talloc_memdup()` here: […]
Noted, will change in the next iteration.
https://gerrit.osmocom.org/c/osmo-msc/+/34517/comment/e06c09a7_1f5bcefa PS1, Line 1260: msgb_free
IMO, this conditional block is a bit out of place here. […]
Noted, will change in the next iteration.