Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email )
Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE
......................................................................
Patch Set 6:
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/6ebdc670_7f77…
PS6, Line 3748: f_pdp_ctx_act(apars);
[packet 478] GGSN (the testsuite) responds with Create
PDP Context Response, but not including the End user address IE;
This looks wrong to me. The EUA should be there. I see no reason why the GGSN would not
assign the EUA.
The testsuite (virtual GGSN) assigns no IP address,
and osmo-sgsn happily accepts that. I don't know if this is right or wrong, you're
saying it's not right?
Ack. One would need to closely read the specs to see if that's allowed, but for sure
it's not what we want in these test cases. It's possibly simply some missing code
in the ttcn3 code emulating the ggsn. Go fix that :)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646
Gerrit-Change-Number: 36601
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Apr 2024 14:02:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment