Attention is currently required from: lynxis lazus.

laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email )

Change subject: s2b: allow to set the restart counter/recovery field ......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5:

I'm not following here. […]

I agree with pespin. If the counter is only 8-bit wide, the probability of accidentially using the same "random" counter value than before is rather low. If it was 32bit or more, I think ok, one can get away with the "random" value... but not at 8 bit.

Whats' wrong with the osmo-ggsn approach of having a file in the filesystem storing a single integer, which gets incremented on every program start? Doesn't sound overly complex to me?