Attention is currently required from: osmith, pespin.

Hello Jenkins Builder, osmith, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/34575?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder

Change subject: gprs_rlcmac_sched: check if we really use direct phy ......................................................................

gprs_rlcmac_sched: check if we really use direct phy

In gprs_rlcmac_sched we have a flag to skip idle frames in case we do not use the so called "direct phy access". A similar mechanism also exists in pcu_l1_if.cpp in function pcu_rx_rts_req_ptcch().

Unfortunately the check is not done correctly. The flag gets set when the ENABLE_DIRECT_PHY define constant is set. However, this does not say much about whether we access a PHY directly or not. The define constant is intended to be used to disable direct phy related code in on platforms where no direct phy code is used or cannot be used.

In order to know if we actually accessing a PHY directly we must check the presence of fl1h on the related TRX. (see also pcu_l1_if.cpp, function pcu_l1if_tx_pdtch) Also since we do not have to guard any platform depended function calls here, we may also remove the conditional compiling.

Related: OS#6191 Change-Id: I0808950b1154bbb9a789c3f706ad9fb6618764ec --- M src/gprs_rlcmac_sched.cpp M src/pcu_l1_if.cpp 2 files changed, 35 insertions(+), 7 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/34575/3