Attention is currently required from: lynxis lazus, pespin.

fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email )

Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case ......................................................................

Patch Set 8:

(3 comments)

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/79ee115d_9d90f... : PS2, Line 2050: [] as_gmm_auth(umts_aka_challenge := true, expect_sai := true) {};

I don't see what's the problem. […]

The problem here is that the expected event flow is unclear and the logic is quite permissive. For instance, it's unclear to me if the IDENTITY.req is expected to be optional or mandatory procedure. AFAICS, you permit the SGSN to not send IDENTITY.req and initiate the authentication straight away despite P-TMSI is unknown.

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/e9393421_11c83... : PS8, Line 2069: If the SGSN follows the rules, this 2nd ATTACH REQ should be ignored, because : * of the same content I am not sure why do we even send GMM ATTACH.req again here (perhaps for the sake of fun?) and why only for IMEI (not for IMSI), but I would like to ask you to not remove this comment. Otherwise the second `f_send_l3()` looks confusing, as if it was accidentally copy-pasted.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/9af8efe7_c1379... : PS8, Line 2116: auth-policy accept-all Unrelated to this patch: is the authentication mandatory now? You mentioned that the ACL will be removed at some point, so does that mean I won't be able to use GPRS with commercial SIM cards for which I have no key material in the HLR?