Attention is currently required from: laforge.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email )
Change subject: gtp/gtp_internal.h: new file
......................................................................
Patch Set 2:
(1 comment)
File gtp/gtp_internal.h:
https://gerrit.osmocom.org/c/osmo-ggsn/+/36068/comment/c652c097_15c15ffc
PS1, Line 3: int gtp_echo_resp(struct gsn_t *gsn, int version,
: struct sockaddr_in *peer, int fd,
: void *pack, unsigned len);
: int gtp_echo_ind(struct gsn_t *gsn, int version,
: struct sockaddr_in *peer, int fd,
: void *pack, unsigned len);
: int gtp_echo_conf(struct gsn_t *gsn, int version,
: struct sockaddr_in *peer, void *pack, unsigned len);
:
: int gtp_unsup_req(struct gsn_t *gsn, int version,
: struct sockaddr_in *peer,
: int fd, void *pack, unsigned len);
: int gtp_unsup_ind(struct gsn_t *gsn, struct sockaddr_in *peer,
: void *pack, unsigned len);
:
: int gtp_create_pdp_resp(struct gsn_t *gsn, int version,
: struct pdp_t *pdp, uint8_t cause);
:
: int gtp_create_pdp_ind(struct gsn_t *gsn, int version,
: struct sockaddr_in *peer, int fd,
: void *pack, unsigned len);
:
: int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
: struct sockaddr_in *peer,
: void *pack, unsigned len);
:
: int gtp_update_pdp_req(struct gsn_t *gsn, int version, void *cbp,
: struct in_addr *inetaddr, struct pdp_t *pdp);
:
: int gtp_delete_pdp_req(struct gsn_t *gsn, int version, void *cbp,
: struct pdp_t *pdp);
:
: int gtp_delete_pdp_resp(struct gsn_t *gsn, int version,
: struct sockaddr_in *peer, int fd,
: void *pack, unsigned len,
: struct pdp_t *pdp, struct pdp_t *linked_pdp,
: uint8_t cause, int teardown);
:
: int gtp_delete_pdp_ind(struct gsn_t *gsn, int version,
: struct sockaddr_in *peer, int fd,
: void *pack, unsigned len);
:
: int gtp_delete_pdp_conf(struct gsn_t *gsn, int version,
: struct sockaddr_in *peer,
: void *pack, unsigned len);
why do those gtp_* symbols need to be non-static and
declared in any header file at all? It looks t […]
right, I've made them static
now (see also new commits before this one).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7
Gerrit-Change-Number: 36068
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 13 May 2024 13:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment