Attention is currently required from: neels, laforge, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 )

Change subject: SS7: do not attempt transfer if AS is down ......................................................................

Patch Set 2:

(2 comments)

File src/osmo_ss7.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/4937c4fe_64d96911 PS2, Line 1151: if (!as->fi) So now we enter the debate whether an unexisting as is down or not. Which in the end imho it doesn't make much sense (like comparing pears and apples). Hence, stop considering this case and simply OSMO_ASSERT(as), as it makes no sense to check if a NULL as is down.

File src/osmo_ss7_hmrt.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/430090f8_bd113aba PS2, Line 234: return -ENETDOWN;

ENETDOWN "Network is down" seems drastic? […]

I'm fine with ENETDOWN, to me that's what's being cecked.