Attention is currently required from: neels, laforge, msuraev.

View Change

2 comments:

• File src/osmo_ss7.c:

  • Patch Set #2, Line 1151: if (!as->fi)

    So now we enter the debate whether an unexisting as is down or not. Which in the end imho it doesn't make much sense (like comparing pears and apples).
    Hence, stop considering this case and simply OSMO_ASSERT(as), as it makes no sense to check if a NULL as is down.

• File src/osmo_ss7_hmrt.c:

  • Patch Set #2, Line 234: return -ENETDOWN;

    ENETDOWN "Network is down" seems drastic? […]

    I'm fine with ENETDOWN, to me that's what's being cecked.

To view, visit change 31295. To unsubscribe, or for help writing mail filters, visit settings.