Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926 )

Change subject: upf/PFCP: do not imply f_inet_addr() ......................................................................

Patch Set 2:

(4 comments)

File hnbgw/HNBGW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/5f1d287d_ca068... PS2, Line 1318: var F_SEID up_f_seid := valueof(ts_PFCP_F_SEID_ipv4(f_inet_addr("127.0.0.1"), '1111111111111111'O)); tip: if you had written the templates below using "template (value)" as parameter you wouldn't need to do "valueof()" here.

File library/PFCP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/e1ddbe66_15b94... PS2, Line 327: template (value) Outer_Header_Creation ts_PFCP_Outer_Header_Creation_GTP_ipv4(OCT4 remote_teid, OCT4 remote_addr_v4) := { here, these params would better be "template (value)" so that they both accept "template (value)" and a value.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/d3877231_3675d... PS2, Line 423: Create_PDR_list create_pdr, same here, these can be "template (value)".

File upf/UPF_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/109bf058_3ba0b... PS2, Line 645: PFCP.send(ts_PFCP_Session_Est_Req(ts_PFCP_Node_ID_ipv4(f_inet_addr(g_pars.local_addr)), nitpick: no need to call f_inet_addr() twice, you can simply store in a local var.