Attention is currently required from: laforge, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email )
Change subject: s2b: answer echo requests
......................................................................
Patch Set 2:
(1 comment)
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900/comment/cd5064d3_219a4... :
PS1, Line 520: IEs = [#v2_recovery{restart_counter = RCnt}],
agreeing with pespin. And indeed it's supposed to increment at every local restart. […]
See the commit following this one (https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/1)
I don't think this should be within this patch, because there is already a recovery/restart counter which is always set to 0.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I3c470bd89b9811ba269b53eb400ffc21db4fba3a
Gerrit-Change-Number: 37900
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 04 Dec 2025 19:18:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de