Attention is currently required from: fixeria, pespin. Hello fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/36518?usp=email to look at the new patch set (#2). Change subject: build/Makefile.asciidoc: fix GIT_DATE ...................................................................... build/Makefile.asciidoc: fix GIT_DATE Omit the "../." parameter from git log. This is legacy from when all manuals were in the osmo-gsm-manuals.git repository, and now causes the wrong date to be used. After removal, it uses the date of the currently checked out git commit again. For most projects using osmo-gsm-manuals, the directory structure looks like the following: ├── doc │   ├── manuals │   │   ├── build -> /usr/share/osmo-gsm-manuals/build │   │   ├── Makefile.am Makefile.am includes build/Makefile.asciidoc.inc. With the "../." parameter, git log parses the date of the last commit of the doc directory. In case of osmo-hnbgw, this is: osmo-hnbgw/doc/manuals $ git log -n1 ../. commit 90928fb2467aef2b2b8419c1c96f7edae6fc2907 Author: Neels Janosch Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Nov 30 18:13:06 2023 +0100 systemd,manual: set LimitNOFILE=65536 ...which then leads to 2023-Nov-30 appearing in the document even though the last commit in the repository is much newer. Fixes: OS#6428 Change-Id: Id46d0d6928c0ad820214280cb36c0c3180f3bff1 --- M build/Makefile.asciidoc.inc 1 file changed, 38 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/18/36518/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/36518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id46d0d6928c0ad820214280cb36c0c3180f3bff1 Gerrit-Change-Number: 36518 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset