Attention is currently required from: osmith, laforge, pespin.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30444 )
Change subject: ctrl: add optional port to bind command
......................................................................
Patch Set 10:
(1 comment)
File src/ctrl/control_if.c:
https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/4a992c95_8a5684c0
PS10, Line 1038: * \param[in] nc Number of CTRL nodes to allocate, 0 for default.
better call this something more descriptive, like
num_nodes. […]
It's not new - it's used by ctrl_interface_setup_dynip2() for
ages. And it's rather widespread: all the failing patches in
https://gerrit.osmocom.org/q/topic:ctrl_init make use of it.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30444
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9
Gerrit-Change-Number: 30444
Gerrit-PatchSet: 10
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Dec 2022 15:48:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment