fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35965?usp=email ) Change subject: libmsc: fix -Wenum-conversion in subscr_conn_toss() ...................................................................... libmsc: fix -Wenum-conversion in subscr_conn_toss() This commit simply fixes a -Wenum-conversion thrown by clang. No idea why are we using the SM (GPRS Session Management) cause values. msc_a_release_mo() does not even use the given SM cause value. Change-Id: Iade6bf97466ab2b3b39e9ea123fc90d06c0f6a9b --- M src/libmsc/sgs_iface.c 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c index ad73289..a845ab8 100644 --- a/src/libmsc/sgs_iface.c +++ b/src/libmsc/sgs_iface.c @@ -124,7 +124,7 @@ LOG_MSUB(msub, LOGL_ERROR, "Force releasing previous subscriber connection: an SGs connection for this" " subscriber is being initiated\n"); - msc_a_release_mo(msub_msc_a(msub), GSM48_REJECT_CONGESTION); + msc_a_release_mo(msub_msc_a(msub), GSM_CAUSE_AUTH_FAILED); /* TODO: is this strong enough? After this, it should be completely disassociated with this subscriber. */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iade6bf97466ab2b3b39e9ea123fc90d06c0f6a9b Gerrit-Change-Number: 35965 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged