Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31732 ) Change subject: rlcmac: Ignore DATA.ind with len=0 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/rlcmac/rlcmac_prim.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/31732/comment/c0cf2c7a_ca956a56 PS1, Line 473: if (rlcmac_prim->l1ctl.pdch_data_ind.data_len == 0) { Maybe use `OSMO_UNLIKELY` here? I am planning to change the modem app to not send DATA.ind with len=0 anyway. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I342c7999261832a5d981e5831e428d2cbd82729e Gerrit-Change-Number: 31732 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 18:50:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment