Attention is currently required from: lynxis lazus, pespin.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email )
Change subject: vlr: Add support for CS and PS timers ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2: I don't really like the fact that you have to pass both timer values everywhere in `vlr_time_secs()`, but I don't know how to do it better. You could add the offset (100) to Txxxx if `vlr_is_ps()` inside of that function and exclusively use the CS timer numbers, but not sure if that's any clearer
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/3829a234_e08ac7c0?usp=... : PS2, Line 1052: T3212 "%s", vlr_is_cs(vsub->vlr) ? "T3212" : "T3312"
-
daniel