Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34478?usp=email )
Change subject: ASCI: MM connections are defined by 'ref' and 'protocol' tuple ......................................................................
Patch Set 5:
(2 comments)
File src/host/layer23/src/mobile/gsm48_mm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34478/comment/7a8ea8ed_4e39e87d PS5, Line 1427: uint32_t ref, uint16_t class) using "class" as param name is asking for trouble eg. when compiling with a C++ compiler due to being a reserved keyword. It is even rendered differently in here in gerrit. Maybe call it "klass".
https://gerrit.osmocom.org/c/osmocom-bb/+/34478/comment/884a8d02_6eb3874c PS5, Line 1449: LOGP(DMM, LOGL_ERROR, "Invalid message class 0x%x. Please fix!", class); 0x02%x?