laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27792 ) Change subject: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE ...................................................................... smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE When responding to a CBSP KILL with a CBSP KILL COMPLETE, make sure we include the optional "Number of Broadcasts Completed List" IE in order to inform the CBC about how many times the just-killed message had been broadcast before it was killed. It seems some CBCs expect this IE to be present, while 3GPP TS 48.049 lists it as optional. Since we alrady have code to encode it, let's just always add it - it certainly won't hurt. Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Closes: SYS#5906 --- M src/osmo-bsc/smscb.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/27792/1 diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 232c0d7..5fe6345 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -651,6 +651,8 @@ if (!smscb) return -CBSP_CAUSE_MSG_REF_NOT_IDENTIFIED; + append_bcast_compl(r_state, chan_state->bts, smscb); + /* Remove it */ bts_smscb_del(smscb, chan_state, "KILL"); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2022q1 Gerrit-Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Gerrit-Change-Number: 27792 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange