Attention is currently required from: fixeria, laforge, pespin.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email )

Change subject: ASCI: Add GCC/BCC (call control) to mobility management ......................................................................

Patch Set 4:

(3 comments)

File src/host/layer23/src/mobile/gsm48_mm.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/643069b1_8f910dbf PS3, Line 789: case GSM48_MMGCC_CLASS:

Maybe some explanation why is this added here ad does nothing?

This is where the receive function for GCC and BCC (call control) is added in a later patch.

https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/7e02431b_21f4ca3d PS3, Line 4096: mm_conn_new_ref++);

Ack

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/b1e81644_348f2537 PS3, Line 4114: || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) {

I would be more careful when saying "wrong". […]

Done