Attention is currently required from: laforge, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/33308
)
Change subject: mgcp-client: Add keepalive feature
......................................................................
Patch Set 4:
(2 comments)
File src/libosmo-mgcp-client/mgcp_client_vty.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/d149e7bc_bb7d2e6d
PS4, Line 311: "Monitor if the MGCP link against MGW is still usable\n"
Maybe "Monitor MGW availability",
or: "Monitor whether the MGCP link towards the MGW is still usable\n"
https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/8ea01e57_de3a6537
PS4, Line 676: pool_member->clien
not sure if it really benefits from operational point
of view, since the MGW in UNKNOWN state should […]
I would use available /
unavailable here. When keepalive is not enabled I would display something like "(not
monitored)"
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/33308
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I3dc74c78548d017f272da863d5282dc5e0020ca3
Gerrit-Change-Number: 33308
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 15:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment