fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 )

Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ......................................................................

Patch Set 1:

(3 comments)

File include/osmocom/gprs/llc/llc.h:

https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/2db55a5b_656301f5 PS1, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */ No, this is how it's written in the specs.

File src/llc/llc_pdu.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/0320af96_224fc7c2 PS1, Line 277: #define check_len(len, text) \ See https://gerrit.osmocom.org/c/osmo-ci/+/29359.

File tests/llc_pdu_codec/pdu_codec_test.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/5973aa03_d88736db PS1, Line 31: static const char *testData[] = { "Should" does not mean "must". This is tests, not critical.