osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30177 ) Change subject: asn1tostruct: don't use f-strings ...................................................................... asn1tostruct: don't use f-strings Make the script work with python < 3.6 again by not using f-strings. Fix for: SyntaxError: invalid syntax File "../../git/asn1/utils/asn1tostruct.py", line 94 f" IE {ie}. Found another entry in ies {ie_other}" \ ^ Fixes: 1d19c8e2 ("asn1tostruct: fix defines getting redefined") Change-Id: I3a19b8a1147532b41d3ed7b802de595302ff8f44 --- M asn1/utils/asn1tostruct.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/asn1/utils/asn1tostruct.py b/asn1/utils/asn1tostruct.py index d71d87d..9b1c1a1 100755 --- a/asn1/utils/asn1tostruct.py +++ b/asn1/utils/asn1tostruct.py @@ -91,8 +91,8 @@ if ie_other[2] == ie[2]: unique = False assert ie[0] != ie_other[0], "failed to find a unique name for" \ - f" IE {ie}. Found another entry in ies {ie_other}" \ - " that has the same ie[0] value." + " IE {}. Found another entry in ies {}" \ + " that has the same ie[0] value.".format(ie, ie_other) if unique: ret = ie[2] -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3a19b8a1147532b41d3ed7b802de595302ff8f44 Gerrit-Change-Number: 30177 Gerrit-PatchSet: 2 Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-MessageType: merged