Attention is currently required from: pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/33891 )
Change subject: osmo-bsc (WIP): Have PCU socket connection use osmo_wqueue
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33891/comment/960559c1_5a623ca6
PS1, Line 845: return -1;
aren't you leaking msgb here? Or is it freed by
the caller?
done by `osmo_wqueue_bfd_cb()`
https://gerrit.osmocom.org/c/osmo-bsc/+/33891/comment/fa21e8dd_d6e43e18
PS1, Line 853: return -1;
aren't you leaking msgb here? Or is it freed by
the caller?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/33891
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5
Gerrit-Change-Number: 33891
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Jul 2023 16:22:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment