Attention is currently required from: fixeria, laforge, lynxis lazus, pespin.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email )

Change subject: Introduce EPDG_Tests testsuite ......................................................................

Patch Set 7: Code-Review+1

(5 comments)

File epdg/EPDG_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/65775eb5_d7308... PS6, Line 19: swtrongswan

strongswan

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/543cc28c_1132f... PS6, Line 216: watchdong

watchdog

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/42a264dd_aba76... PS6, Line 231: /* TODO: maybe use, set to true */

the comment? yes, it's for next stages.

Ack

File epdg/gen_links.sh:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/e0087b88_08773... PS6, Line 30: #FILES+="SS_DataTypes.asn SS_Errors.asn SS_Operations.asn SS_PDU_Defs.asn SS_Protocol.asn SS_Types.ttcn SS_EncDec.cc"

commented out FILES here looks like left-overs that should be removed?

Done

File library/DIAMETER_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/1c577b62_63eef... PS6, Line 2295: //tr_AVP_3GPP_IntegrityKey(?) /* Optional */

I think it's fine for now, it helps people find the related templates/types.

Ack