Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email )

Change subject: gtp: add support for SGSN Context Req/Resp/Ack ......................................................................

Patch Set 11:

(6 comments)

File include/osmocom/gtp/gsn.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21540): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/ea4217b9_962b80cb?usp... : PS11, Line 116: int (*cb_sgsn_context_request_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21540): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/fb89b130_b96f8de5?usp... : PS11, Line 117: int (*cb_sgsn_context_response_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21540): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/0836533b_802f0ce6?usp... : PS11, Line 118: int (*cb_sgsn_context_ack_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21540): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e6f8afae_8bfcb178?usp... : PS11, Line 169: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21540): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e40e4b5c_4c1a0874?usp... : PS11, Line 172: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21540): https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/eca11dd0_c308ba62?usp... : PS11, Line 175: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size)); Unnecessary space before function pointer arguments