Attention is currently required from: fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283?usp=email )
Change subject: mgw: add TC_crcx_iufp_sendrecv and _recvonly
......................................................................
Patch Set 1:
(1 comment)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283/comment/2867beb6_6598c...
PS1, Line 2850: not ispresent(resp.sdp)
This is not needed, since `ispresent()` is safe against `foo.omit.bar`. `not ispresent(resp.sdp. […]
I copied it from elsewhere, so I'll rather keep it the same, and put hopes in a separate patch that fixes all the occurences of this code snippet...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I00fd854f058f7f53e2f579e8481ca2b9253f08e3
Gerrit-Change-Number: 37283
Gerrit-PatchSet: 1
Gerrit-Owner: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 02 Jul 2024 01:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment