Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email )

Change subject: osmo-bts-trx: apply 'max-initial' value before POWERON ......................................................................

Patch Set 2:

(2 comments)

File src/osmo-bts-trx/trx_provision_fsm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/01a50c10_38ae3a9d?usp=... : PS2, Line 229: l1h->config.setpower_sent = true; Missing: "l1h->config.nomtxpower_acked = false;" At the moment we sent a new message in flight we consider the ack condition to be not fullfilled.

Since all this is already complex enough with tons of stuff happening concurrently based on different inputs from upper and lowers layers, best to be safe and follow the guideline. It also helps when debugging.

https://gerrit.osmocom.org/c/osmo-bts/+/42033/comment/3fd18593_1c4bec7e?usp=... : PS2, Line 294: (l1h->config.setformat_acked) && This () can actually be dropped, instead of adding new ones 😊