Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653 ) Change subject: debian: add generate_build_dep.sh to vendor erlang dependencies ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653/comment/fb1c5a7b_… PS1, Line 8: the plan is to run this while generating source packages in the jenkins jobs, I'd mention it here. File contrib/generate_build_dep.sh: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653/comment/44e7df20_… PS1, Line 1: #!/bin/sh #!/bin/sh -e so it fails if one of the commands fail? https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653/comment/eb2e4eb8_… PS1, Line 10: I'd add "set -x" here so we see the commands, in case one fails -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I22041887fd1b72ea328605d18801d412b86bfc9c Gerrit-Change-Number: 28653 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 19 Jul 2022 10:46:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment