[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module - gerrit-log

10 Dec 2025


      Attention is currently required from: fixeria, lynxis lazus, pespin.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email )
Change subject: s2b: when socket opening fails, stop the S2b module
......................................................................
Patch Set 5:
(1 comment)
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/57f630fc_bcc8b... :
PS3, Line 150: io_lib:format
...
Well, the general approach is that formatted strings are for humans. […]
I agree with fixeria
-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd
Gerrit-Change-Number: 37901
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 10 Dec 2025 13:39:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: lynxis lazus lynxis@fe80.eu