Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email )

Change subject: client: use osmo_stream_cli to transmit data to pcap-server ......................................................................

Patch Set 4: Code-Review+1

(2 comments)

File src/osmo_client_network.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/39944/comment/5ed01889_0a982245?usp... : PS4, Line 83: cannot never * cannot never? * does this make sense with io_uring, given that it is async I guess we can't get an error here in any case?

https://gerrit.osmocom.org/c/osmo-pcap/+/39944/comment/87d7de1a_5fced108?usp... : PS4, Line 137: int conn_cb(struct osmo_fd *fd, unsigned int what) maybe also name it conn_cb_tls?